PMC QA Meeting 20100609
Date: 2010-06-09
Time: 12PM GMT
Venue: irc #adempiere-team
Support Spreadsheet: Adempiere PMC QA
Chat times in GMT-5
(06:55:40) interopen [~interopen@141.Red-80-25-232.staticIP.rima-tde.net] entered the channel.
(07:00:15) CarlosRuiz: Hi Ivan
(07:01:32) interopen: Hi Carlos
(07:02:06) CarlosRuiz: how are things going?
(07:03:14) interopen: fine, working on try to have the public server, but still not there
(07:04:05) interopen: on the sahi side, all things more clear now, no mayor problems
(07:05:08) CarlosRuiz: great to know that
(07:05:19) interopen: so just is needed more work on it, develop
(07:05:51) interopen: i see there is an update of the wiki today, great they will add a freemind module
(07:06:34) interopen: and i was reviewing the task list now
(07:08:26) CarlosRuiz: yep - new wiki has a helpful toolbar for edits also
(07:09:37) interopen: that is good, see if we can have more use with it
(07:27:20) interopen: one question about task 12
(07:27:48) interopen: can QA group create this task and be implemented at least in release?
(07:29:34) interopen: as fro now the only information i find is this one http://www.adempiere.com/index.php/Developer's_Technical_Manual#How_to_write_a_test
(07:37:44) CarlosRuiz: I feel we're not mature to force that
(07:38:25) red1 [~red1@175.137.112.13] entered the channel.
(07:39:06) CarlosRuiz: very few people contributing - adding such strict requirement could discourage the few contributors we have
(07:39:06) CarlosRuiz: my thinking is we must do it in steps
(07:39:35) CarlosRuiz: first as a recommendation - with documentation and "training" about how and when to write a test case (not always applicable)
(07:39:36) interopen: not even with the bugs triage or bugs days?
(07:39:44) red1: nope
(07:41:09) CarlosRuiz: bug triage? just two persons doing it
(07:41:09) CarlosRuiz: bug days? just four persons were there last time
(07:41:53) interopen: we can not avoid non-stable code getting into release with this rules?
(07:42:56) red1: Release branch is under strict control so i guess we can control that
(07:43:35) red1: to be fair, there are quite a number of disciplined committers, i think i can count about 10
(07:43:36) CarlosRuiz: Ivan - I'm pro that rule - just saying that initially it must not be a rule, but a recommendation, and when mature we establish it as a rule
(07:43:39) interopen: yes, but if we force any new code to come with a test, is the way to easily review it
(07:44:10) CarlosRuiz: "disciplined" committers? I just can count two
(07:44:24) CarlosRuiz: Ivan - "force" is the word that I don't want to apply at this moment
(07:44:27) red1: ok lets count...
(07:44:41) interopen: Carlos, ok we still move with recomendations
(07:45:33) CarlosRuiz: now - junit tests are not applicable for all contributions - so we need to establish when they are recommended (later forced)
(07:46:06) interopen: can you give examples of what contributions are not applicable?
(07:46:48) CarlosRuiz: dictionary changes - UI changes?
(07:47:32) interopen: ok, for dictionary changes we will use sahi
(07:47:38) CarlosRuiz: junit tests are most applicable for business methods - like Tax, or beforeSave/afterSave
(07:48:09) CarlosRuiz: but changing the behavior of grid editor - I don't see clearly how a junit can test that
(07:49:37) interopen: ok, so first is define where is applicable
(07:49:57) CarlosRuiz: IMHO the recommendation would be - new business functionalities must be accompanied by one or more junit tests
(07:50:15) CarlosRuiz: indeed recommendation is to write the junit test before writing the code to solve the problem
(07:50:38) interopen: if fact it should be
(07:50:53) CarlosRuiz: but as we have so scarcity of resources I prefer to go in the "recommendation" and "best practices" way until now
(07:50:56) interopen: in (not if)
(07:51:57) interopen: yes, we are always with the lack of resources issue
(07:52:19) CarlosRuiz: and initially go in the "training" mode
(07:52:57) interopen: you mean first task 13 and later 12
(07:53:29) CarlosRuiz: not necessarily
(07:53:44) CarlosRuiz: junit tests are written by developers - when writing code
(07:53:54) CarlosRuiz: functional test cases ideally can be written by end users
(07:54:20) interopen: yes, that is clearly the objective
(07:54:45) interopen: also we made some documentation to integrate both, i remember
(07:55:08) interopen: http://www.adempiere.com/index.php/PMC:QA:Junit_and_Sahi
(07:55:22) interopen: http://www.adempiere.com/index.php/PMC:QA:Sahi_junit_test_for_Adempiere_SO_order
(07:56:24) trifon [~trifon@91-67-146-116-dynip.superkabel.de] entered the channel.
(08:04:15) interopen: ok, so we finish here, and continue the work...
(08:04:32) interopen: thanks Carlos for the help
(08:04:54) CarlosRuiz: thanks to you Ivan
